Re: [PATCH wireless-next 32/35] dt-bindings: net: wireless: morsemicro: add mm81x family

[Krzysztof Kozlowski]

On Fri, Feb 27, 2026 at 03:10:42PM +1100, Lachlan Hodges wrote:
> Add dt-bindings describing the Morse Micro mm81x family of
> chips.

Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

> 
> Signed-off-by: Lachlan Hodges <lachlan.hodges@xxxxxxxxxxxxxx>
> ---
>  .../net/wireless/morsemicro,mm81x.yaml        | 74 +++++++++++++++++++
>  1 file changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/wireless/morsemicro,mm81x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/morsemicro,mm81x.yaml b/Documentation/devicetree/bindings/net/wireless/morsemicro,mm81x.yaml
> new file mode 100644
> index 000000000000..653a7476cf8f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/morsemicro,mm81x.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/morsemicro,mm81x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Morse Micro MM81x
> +
> +maintainers:
> +  - Lachlan Hodges <lachlan.hodges@xxxxxxxxxxxxxx>
> +  - Arien Judge <arien.judge@xxxxxxxxxxxxxx>
> +
> +description: >
> +  This node provides properties for configuring a Morse Micro MM81x device
> +  connected via SDIO. The node shall be specified as a child node of an SDIO
> +  controller.

Drop sentences, redunadnt. Explain the device/hardware, not the DT. We
all know how to construct DT.

> +
> +  It is recommended to declare a mmc-pwrseq on SDIO host above MM81x. Without

No. It is not. Drop,.

> +  it, you may encounter issues during reboot. The mmc-pwrseq should be
> +  compatible with mmc-pwrseq-simple. Please consult
> +  Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml for more
> +  information.

Nothing here is relevant. You must explain the hardware, not quirks
specific to kernel.

> +
> +properties:
> +  compatible:
> +    items:
> +      - const: morsemicro,mm81x

What is 'x'? Wild-cards are not allowed, see numerous talks and writing
bindings.

> +
> +  reg:
> +    description:
> +      <reg> must be set to 2.

Why? No, drop description.

> +    maxItems: 1
> +
> +  wake-gpios:
> +    description: Phandle of gpio that will be used to wake up the chip. Powersave
> +      features disabled if property not present.
> +    maxItems: 1
> +
> +  busy-gpios:
> +    description: Phandle of a gpio that is used to indicate the chip has data
> +      ready.

Drop redundant "PHandle of a gpio that is". It cannot be anything else.
Same in the oter place.

OTOH, missing constraints/maxItems.

> +
> +required:
> +  - compatible
> +  - reg

You need $ref to wireless-controller.yaml.

> +
> +additionalProperties: false

and this becomes unevaluatedProperties

> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    mm81x_pwrseq: mm81x_pwrseq {

Drop entire node, not really correct and not needed.

> +        compatible = "mmc-pwrseq-simple";
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&mm81x_reset>;
> +        reset-gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
> +    };
> +
> +    mmc {
> +        mmc-pwrseq = <&mm81x_pwrseq>;

Drop property irrelevant.

> +        #address-cells = <1>;
> +        #size-cells = <0>;


> +
> +        wifi@0 {

Not tested. You said before it has to be 2, not 0.

> +            compatible = "morsemicro,mm81x";
> +            pinctrl-names = "default";
> +            pinctrl-0 = <&mm81x_busy>, <&mm81x_wake>;
> +            reg = <2>;

Follow DTS coding style.

> +            wake-gpios = <&gpio 12 GPIO_ACTIVE_HIGH>;
> +            busy-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
> +        };
> +    };
> +...
> -- 
> 2.43.0
>