Re: [PATCH v3 5/8] clk: versaclock3: Prefix clock names with DT node name

[Geert Uytterhoeven]

Hi Ovidiu,

On Tue, 3 Feb 2026 at 14:52, Ovidiu Panait <ovidiu.panait.rb@xxxxxxxxxxx> wrote:
> Similar to commit f491276a5168 ("clk: vc5: Allow Versaclock driver to
> support multiple instances"), prefix clock names with the device tree
> node name to allow multiple VersaClock3 devices to be registered
> simultaneously.
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait.rb@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/clk/clk-versaclock3.c
> +++ b/drivers/clk/clk-versaclock3.c
> @@ -1137,6 +1137,7 @@ static int vc3_register_clk(struct vc3_device_data *vc3,
>         struct device *dev = &vc3->client->dev;
>         struct clk_parent_data *pd;
>         struct clk_init_data init;
> +       const char *name;
>         int ret;
>
>         if (!hw_data->data)
> @@ -1147,7 +1148,15 @@ static int vc3_register_clk(struct vc3_device_data *vc3,
>         if (!pd)
>                 return -ENOMEM;
>
> +       name = kasprintf(GFP_KERNEL, "%pOFn.%s", dev->of_node,
> +                        template->hw.init->name);

"%pOFn" is still not unique.  As per the Generic Names Recommendation
in the Devicetree Specification, it should be "clock-controller"
everywhere.  Using the I2C device name instead should work fine.
The same issue is present in the Versaclock 5 driver (but
e.g. beacon-renesom-som.dtsi uses "versaclock-som").

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds