Re: [PATCH 1/2] dt-bindings: hwmon: Add DT schema for TI INA4230

[Alexey Charkov]

On Fri, Feb 27, 2026 at 1:53 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Wed, Feb 25, 2026 at 01:29:11PM +0400, Alexey Charkov wrote:
> > Add DT binding for TI INA4230, which is a 48V 4-channel 16-bit I2C-based
> > current/voltage/power/energy monitor with alert function.
> >
>
> A nit, subject: drop second/last, redundant "DT schema". The
> "dt-bindings" prefix is already stating that this DT and this cannot be
> non-schema.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Ack, will drop in v2.

> > +patternProperties:
> > +  "^input@[0-3]$":
> > +    description: The node contains optional child nodes for four channels.
> > +      Each child node describes the information of input source. Input channels
> > +      default to enabled in the chip. Unless channels are explicitly disabled
> > +      in device-tree, input channels will be enabled.
> > +    type: object
> > +    additionalProperties: false
> > +    properties:
> > +      reg:
> > +        description: Must be 0, 1, 2 or 3, corresponding to the IN1, IN2, IN3
> > +          or IN4 ports of the INA4230, respectively.
> > +        enum: [ 0, 1, 2, 3 ]
> > +
> > +      label:
> > +        description: name of the input source
> > +
> > +      shunt-resistor-micro-ohms:
> > +        description: shunt resistor value in micro-Ohm
> > +
> > +      ti,maximum-expected-current-microamp:
>
> Please add it also to the example at least to one node.

Ack, will add in v2.

> With these two fixes:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Thanks for your review Krzysztof!

Best regards,
Alexey