[PATCH] crypto: qat - Drop redundant local variables

From: Thorsten Blum

Date: Fri Feb 27 2026 - 06:55:55 EST


Return sysfs_emit() directly and drop 'ret' in cap_rem_show().

In cap_rem_store(), use 'ret' when calling set_param_u() instead of
assigning it to 'val' first, and remove 'val'.

Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
---
drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c b/drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c
index f31556beed8b..89bfd8761d75 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c
@@ -321,7 +321,7 @@ static ssize_t cap_rem_show(struct device *dev, struct device_attribute *attr,
{
struct adf_rl_interface_data *data;
struct adf_accel_dev *accel_dev;
- int ret, rem_cap;
+ int rem_cap;

accel_dev = adf_devmgr_pci_to_accel_dev(to_pci_dev(dev));
if (!accel_dev)
@@ -336,23 +336,19 @@ static ssize_t cap_rem_show(struct device *dev, struct device_attribute *attr,
if (rem_cap < 0)
return rem_cap;

- ret = sysfs_emit(buf, "%u\n", rem_cap);
-
- return ret;
+ return sysfs_emit(buf, "%u\n", rem_cap);
}

static ssize_t cap_rem_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
- unsigned int val;
int ret;

ret = sysfs_match_string(rl_services, buf);
if (ret < 0)
return ret;

- val = ret;
- ret = set_param_u(dev, CAP_REM_SRV, val);
+ ret = set_param_u(dev, CAP_REM_SRV, ret);
if (ret)
return ret;

--
Thorsten Blum <thorsten.blum@xxxxxxxxx>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4