Re: [PATCH RFT v2 1/2] arm64: dts: qcom: glymur: Describe display related nodes

[Dmitry Baryshkov]

On Fri, Feb 27, 2026 at 01:47:44PM +0200, Abel Vesa wrote:
> On 26-01-13 19:48:07, Dmitry Baryshkov wrote:
> > On Tue, Jan 13, 2026 at 05:00:05PM +0200, Abel Vesa wrote:
> > > From: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > > 
> > > The MDSS (Mobile Display SubSystem) on Glymur comes with 4 DisplayPort
> > > controllers. Describe them along with display controller and the eDP
> > > PHY. Then, attach the combo PHYs link and vco_div clocks to the Display
> > > clock controller and link up the PHYs and DP endpoints in the graph.
> > > 
> > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > > ---
> > >  arch/arm64/boot/dts/qcom/glymur.dtsi | 431 ++++++++++++++++++++++++++++++++++-
> > >  1 file changed, 423 insertions(+), 8 deletions(-)
> > > 
> > > +
> > > +			mdss_dp0: displayport-controller@af54000 {
> > > +				compatible = "qcom,glymur-dp";
> > > +				reg = <0x0 0xaf54000 0x0 0x104>,
> > > +				      <0x0 0xaf54200 0x0 0xc0>,
> > > +				      <0x0 0xaf55000 0x0 0x770>,
> > > +				      <0x0 0xaf56000 0x0 0x9c>,
> > > +				      <0x0 0xaf57000 0x0 0x9c>;
> > 
> > A quick look at the memory map points out that you missed p2 / p3 /
> > mst_2_lclk / mst_3_lclk. Is memory map incorrect?
> 
> Sorry for the late reply.
> 
> Will fix.
> 
> > 
> > > +
> > > +				interrupts-extended = <&mdss 12>;
> > > +
> > > +				clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_AUX_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_LINK_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_PIXEL0_CLK>,
> > > +					 <&dispcc DISP_CC_MDSS_DPTX0_PIXEL1_CLK>;
> > > +				clock-names = "core_iface",
> > > +					      "core_aux",
> > > +					      "ctrl_link",
> > > +					      "ctrl_link_iface",
> > > +					      "stream_pixel";
> > 
> > This wasn't actually tested. You have 6 clocks but 5 clock-names.
> 
> Well, that's why it is RFT ... :-)

Please don't post the code that is not expected to work or that doesn't
pass minimum sanity checks.

> 
> Will fix.
> 
> Thank you for reviewing!

-- 
With best wishes
Dmitry