Re: [PATCH v6 7/9] dt-bindings: PCI: tegra194: Add monitor clock support

From: Vidya Sagar

Date: Fri Feb 27 2026 - 07:42:21 EST


On 24/02/26 00:15, Manikanta Maddireddy wrote:
> From: Vidya Sagar <vidyas@xxxxxxxxxx>
>
> Tegra supports PCIe core clock monitoring for any rate changes that may be
> happening because of the link speed changes. This is useful in tracking
> any changes in the core clock that are not initiated by the software.
>
> Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>
> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
> Changes V5 -> V6: None
> Changes V4 -> V5: Fixed clock description per review comment
> Changes V1 -> V4: None
>
> .../devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml | 6 +++++-
> .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml | 6 +++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
> index 6d6052a2748f..7805757f2e2d 100644
> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie-ep.yaml
> @@ -55,12 +55,16 @@ properties:
> - const: intr
>
> clocks:
> + minItems: 1
> items:
> - - description: module clock
> + - description: core clock
> + - description: monitor clock
>
> clock-names:
> + minItems: 1
> items:
> - const: core
> + - const: core_m
>
> resets:
> items:
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> index fe81d52c7277..41041ae7e0a4 100644
> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> @@ -58,12 +58,16 @@ properties:
> - const: msi
>
> clocks:
> + minItems: 1
> items:
> - - description: module clock
> + - description: core clock
> + - description: monitor clock
>
> clock-names:
> + minItems: 1
> items:
> - const: core
> + - const: core_m
>
> resets:
> items:

Reviewed-by: Vidya Sagar <vidyas@xxxxxxxxxx>