Re: [PATCH] iio: adc: ade9000: fix wrong macro names in ADE9000_ST_ERROR
From: Andy Shevchenko
Date: Fri Feb 27 2026 - 09:46:42 EST
On Fri, Feb 27, 2026 at 02:52:45PM +0400, Giorgi Tchankvetadze wrote:
> On Fri, Feb 27, 2026 at 2:33 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
>
> > What about the current code that uses it? Is it even in use currently?
> >Please, elaborate more in the commit message that we clearly understand
> >that you spent time and investigated code and/or datasheet before crafting
> >this change.
>
> Hi Andy. Thanks for the feedback !
> The macro is currently unused in the driver, so this does not cause
> a build failure.
Drop it then?
> Reference: ADE9000 datasheet (Rev. B, Page 61), STATUS1 register (0x403),
> bits 28-31 define ERROR0 through ERROR3 status flags.
Yes, good, this should be in the commit message.
--
With Best Regards,
Andy Shevchenko