Re: [PATCH 1/8] dt-bindings: media: i2c: document Omnivision OV08D10 CMOS image sensor

[Matthias Fend]

Hi Krzysztof,

thanks for your comments.

Am 27.02.2026 um 11:45 schrieb Krzysztof Kozlowski:
> On Thu, Feb 26, 2026 at 09:56:01AM +0100, Matthias Fend wrote:
> > Add YAML bindings for the Omnivision OV08D10 CMOS image sensor.
>
> Drop YAML. You add DT bindings, not YAML. No YAML is bound here to
> anything.

ACK

> > Signed-off-by: Matthias Fend <matthias.fend@xxxxxxxxx>
> > ---
> >   .../bindings/media/i2c/ovti,ov08d10.yaml           | 101 +++++++++++++++++++++
> >   MAINTAINERS                                        |   1 +
> >   2 files changed, 102 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov08d10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov08d10.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..96dbf61cf7c188544f4120216ae2b8e0155128b7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov08d10.yaml
> > @@ -0,0 +1,101 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov08d10.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Omnivision OV08D10 1/4-Inch 8MP CMOS color image sensor
> > +
> > +maintainers:
> > +  - Jimmy Su <jimmy.su@xxxxxxxxx>
> > +
> > +description:
> > +  The Omnivision OV08D10 is a 1/4-Inch 8MP CMOS color image sensor with an
> > +  active array size of 3280 x 2464. It is programmable through I2C
> > +  interface. Image data is transmitted via MIPI CSI-2 using 2 lanes.
> > +
> > +allOf:
> > +  - $ref: /schemas/media/video-interface-devices.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: ovti,ov08d10
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    description: MCLK input clock (6 - 27 MHz)
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    description: Active low XSHUTDN pin
>
> So maybe rather powerdown-gpios, see gpio-consumer-common.yaml?

As activating the XSHUTDN pin on this sensor works like a reset, I guess 
it's okay as it is.

From what I've seen, it's also common practice for some other 
Omnivision sensors to designate the XSHUTDN pin as the reset pin.
This is also the case, for example, with the recently added OS05B10.

During a review for another sensor, I was asked to use the reset 
controller framework instead of the GPIO pin for the reset function, 
which I did in this case as well.
To my knowledge, the fallback from the reset controller to a simple 
reset pin only works with the 'reset-gpios' property.

Thanks
 ~Matthias

> > +    maxItems: 1
>
> Best regards,
> Krzysztof