Re: [PATCH v2] fs: remove stale and duplicate forward declarations

[Jan Kara]

On Thu 26-02-26 20:18:58, Yuto Ohnuki wrote:
> Remove the following unnecessary forward declarations from fs.h, which
> improves maintainability.
> 
> - struct hd_geometry: became unused in fs.h when
>   block_device_operations was moved to blkdev.h in commit 08f858512151
>   ("[PATCH] move block_device_operations to blkdev.h"). The forward
>   declaration is now added to blkdev.h where it is actually used.
> 
> - struct iovec: became unused when aio_read/aio_write were removed in
>   commit 8436318205b9 ("->aio_read and ->aio_write removed")
> 
> - struct iov_iter: duplicate forward declaration. This removes the
>   redundant second declaration, added in commit 293bc9822fa9
>   ("new methods: ->read_iter() and ->write_iter()")
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512301303.s7YWTZHA-lkp@xxxxxxxxx/
> Closes: https://lore.kernel.org/oe-kbuild-all/202512302139.Wl0soAlz-lkp@xxxxxxxxx/
> Closes: https://lore.kernel.org/oe-kbuild-all/202512302105.pmzYfmcV-lkp@xxxxxxxxx/
> Closes: https://lore.kernel.org/oe-kbuild-all/202512302125.FNgHwu5z-lkp@xxxxxxxxx/
> Closes: https://lore.kernel.org/oe-kbuild-all/202512302108.nIV8r5ES-lkp@xxxxxxxxx/
> Signed-off-by: Yuto Ohnuki <ytohnuki@xxxxxxxxxx>

Makes sense. Thanks. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
> Changes in v2:
> - Add forward declaration of struct hd_geometry to blkdev.h to fix
>   build errors reported by kernel test robot.
> - Verified with allmodconfig build and all configs reported by 
>   kernel test robot.
> 
> v1: https://lore.kernel.org/lkml/20251229071401.98146-1-ytohnuki@xxxxxxxxxx/
> ---
>  include/linux/blkdev.h | 1 +
>  include/linux/fs.h     | 3 ---
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index d463b9b5a0a5..0b5942e08754 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -38,6 +38,7 @@ struct blk_flush_queue;
>  struct kiocb;
>  struct pr_ops;
>  struct rq_qos;
> +struct hd_geometry;
>  struct blk_report_zones_args;
>  struct blk_queue_stats;
>  struct blk_stat_callback;
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 8b3dd145b25e..75c97faf8799 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -55,8 +55,6 @@ struct bdi_writeback;
>  struct bio;
>  struct io_comp_batch;
>  struct fiemap_extent_info;
> -struct hd_geometry;
> -struct iovec;
>  struct kiocb;
>  struct kobject;
>  struct pipe_inode_info;
> @@ -1917,7 +1915,6 @@ struct dir_context {
>   */
>  #define COPY_FILE_SPLICE		(1 << 0)
>  
> -struct iov_iter;
>  struct io_uring_cmd;
>  struct offset_ctx;
>  
> -- 
> 2.50.1
> 
> 
> 
> 
> Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
> 
> Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
> 
> 
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR