Re: [PATCH v1] media: aspeed: Fix driver probe failure

[Krzysztof Kozlowski]

On 27/02/2026 16:18, Haiyue Wang wrote:
> 
> 
> On 2/27/2026 8:59 PM, Krzysztof Kozlowski wrote:
>> On 27/02/2026 13:38, Haiyue Wang wrote:
>>> The aspeed video (be compatible for ast2400, ast2500, ast2600) now needs
>>> the reset DTS handle specified, otherwise it will fail to load:
>>>
>>> [    0.000000] OF: reserved mem: initialized node video, compatible id shared-dma-pool
>>> [    0.000000] OF: reserved mem: 0xbb000000..0xbeffffff (65536 KiB) map reusable video
>>> [    0.377039] videodev: Linux video capture interface: v2.00
>>> [    4.809494] aspeed-video 1e700000.video: irq 57
>>> [    4.809977] aspeed-video 1e700000.video: Unable to get reset
>>> [    4.810341] aspeed-video 1e700000.video: probe with driver aspeed-video failed with error -2
>>>
>>> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
>>> Signed-off-by: Haiyue Wang <haiyuewa@xxxxxxx>
>>> ---
>>>   arch/arm/boot/dts/aspeed/aspeed-g4.dtsi   | 1 +
>>>   arch/arm/boot/dts/aspeed/aspeed-g5.dtsi   | 1 +
>>>   arch/arm/boot/dts/aspeed/aspeed-g6.dtsi   | 1 +
>>>   include/dt-bindings/clock/ast2600-clock.h | 1 +
>>
>> Please run scripts/checkpatch.pl on the patches and fix reported
>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>> patches and (probably) fix more warnings. Some warnings can be ignored,
>> especially from --strict run, but the code here looks like it needs a
>> fix. Feel free to get in touch if the warning is not clear.
>>
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>>
> 
> Seperated into two patches in v2, please help to review.

No, please wait. One posting per day. We have enough of other patches to
review.

Best regards,
Krzysztof