Re: [PATCH v1 2/3] lib: math: polynomial: Don't use 'proxy' headers
From: Andy Shevchenko
Date: Fri Feb 27 2026 - 11:29:12 EST
On Sat, Feb 28, 2026 at 12:13:34AM +0800, Kuan-Wei Chiu wrote:
> On Fri, Feb 27, 2026 at 08:47:59AM +0100, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
...
> > -#include <linux/kernel.h>
> > +#include <linux/export.h>
> > #include <linux/module.h>
#include <linux/math.h>
> > #include <linux/polynomial.h>
>
> Since polynomial.c uses mult_frac(), perhaps we should also add an
> explicit #include <linux/math.h>?
Good point! I missed it somehow. Andrew, do you want a new version or can you
amend that in this patch?
Thanks for the review!
--
With Best Regards,
Andy Shevchenko