Re: [patch 35/48] entry: Prepare for deferred hrtimer rearming

[Christian Loehle]

On 2/27/26 16:25, Peter Zijlstra wrote:
> On Fri, Feb 27, 2026 at 03:57:55PM +0000, Christian Loehle wrote:
> 
>>> @@ -239,7 +252,7 @@ static __always_inline void __exit_to_us
>>>  /* Temporary workaround to keep ARM64 alive */
>>>  static __always_inline void exit_to_user_mode_prepare_legacy(struct pt_regs *regs)
>>>  {
>>> -	__exit_to_user_mode_prepare(regs);
>>> +	__exit_to_user_mode_prepare(regs, EXIT_TO_USER_MODE_WORK);
>>
>> Should this also be EXIT_TO_USER_MODE_WORK_IRQ?
>> I guess it doesn't really matter for now (since arm64 doesn't have the generic entry
>> path and generic TIF bits yet and therefore HRTIMER_REARM_DEFERRED=n), but I've been
>> playing around with the this series, the generic entry series
>> https://lore.kernel.org/lkml/20260203133728.848283-1-ruanjinjie@xxxxxxxxxx
>> (and using generic TIF bits) and noticed this.
> 
> I'm confused; if ARM64 goes GENERIC_ENTRY, its use of legacy should go
> away and we can delete that whole thing, no?

Duh, the confusion was on my side
Let me check why the conversion again and see why it wouldn't, if there's a reason...