Re: [PATCH v6 0/9] Enhancements to pcie-tegra194 driver

[Jon Hunter]

On 23/02/2026 18:45, Manikanta Maddireddy wrote:
> This series[1] was originally posted by Vidya Sagar, and I have rebased
> it onto 6.19.0-rc6-next. I addressed review comments and split this into
> two series, one for fixes and the other is for enhancements(current).
> I verified these patches on Jetson AGX Orin(Tegra234 SoC).
>
> Disabling L1SS capability based on support-clkreq device tree property
> is moved to common DWC driver, so I reworked below patch to disable
> just L1.2 capability on Tegra234 SoC.
>   - PCI: tegra194: Disable L1.2 capability of Tegra234 EP
>
> I added below new patch to tune the ASPM parameters, commit message of the
> patch has the details on the bug and fix.
>   - PCI: tegra194: Add ASPM L1 entrance latency config
>
> I added more context in the commit message for below patch based on review
> comment in V3.
>   - PCI: tegra194: Remove IRQF_ONESHOT flag during Endpoint interrupt registration
>
> Rest of the patches are same as the original V3 series, just rebased them on
> 6.19.0-rc6-next.
>
> I fixed the missing PATCH prefix in the subject in V6.
>
> Verification details.
>   - I verified both Root port and Endpoint mode controllers on Tegra234 SoC.
>   - Basic sanity Link up, configuration space access and BAR access are verified.
>   - I verified that ASPM L1.2 capability is disabled for Endpoint mode.
>   - I verified suspend to RAM tests with Endpoint mode.
>
> [1] https://patchwork.kernel.org/project/linux-pci/patch/20221013183854.21087-1-vidyas@xxxxxxxxxx/
>
> Manikanta Maddireddy (1):
>    PCI: tegra194: Add ASPM L1 entrance latency config
>
> Vidya Sagar (8):
>    PCI: tegra194: Drive CLKREQ signal low explicitly
>    PCI: tegra194: Calibrate P2U for endpoint mode
>    PCI: tegra194: Remove IRQF_ONESHOT flag during Endpoint interrupt
>      registration
>    PCI: tegra194: Enable DMA interrupt
>    PCI: tegra194: Enable hardware hot reset mode in Endpoint
>    PCI: tegra194: Disable L1.2 capability of Tegra234 EP
>    dt-bindings: PCI: tegra194: Add monitor clock support
>    PCI: tegra194: Add core monitor clock support
>
>   .../bindings/pci/nvidia,tegra194-pcie-ep.yaml |  6 +-
>   .../bindings/pci/nvidia,tegra194-pcie.yaml    |  6 +-
>   drivers/pci/controller/dwc/pcie-tegra194.c    | 67 ++++++++++++++++++-
>   3 files changed, 76 insertions(+), 3 deletions(-)

For the series ...

Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>
Tested-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks
Jon

--
nvpublic