Re: [PATCH v2] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c

From: Ethan Tidmore

Date: Fri Feb 27 2026 - 12:19:17 EST


On Fri Feb 27, 2026 at 10:39 AM CST, Dan Carpenter wrote:
> On Fri, Feb 27, 2026 at 09:18:24AM -0600, Ethan Tidmore wrote:
>> On Fri Feb 27, 2026 at 2:46 AM CST, Jose A. Perez de Azpillaga wrote:
>> > Replace msleep() with fsleep() in rtw_cmd.c to improve delay
>> > precision and follow modern kernel practices.
>> >
>> > Specifically, this fixes a checkpatch warning for the 10ms delay
>> > in _rtw_free_evt_priv() and updates the 100ms polling loops in
>> > rtw_chk_hi_queue_hdl() and rtw_free_cmd_priv() for consistency.
>> >
>> > Signed-off-by: Jose A. Perez de Azpillaga <azpijr@xxxxxxxxx>
>> > ---
>> > v2: changed to USEC_PER_MSEC instead of magic numbers
>> > ---
>> ^^^
>> Remove this.
>>
>
> Having an extra --- cut off line doesn't matter. The other thing that
> you sometimes see is an extra blank line before the --- cut off line
> and that's fine too.
>
> regards,
> dan carpenter

Oh ok, nice to know. I guess I assumed the last cut of line was the one
that counted.

Thanks,

ET