Re: [RFC v1 0/8] acpi/x86: s2idle: Introduce and implement runtime standby ABI for ACPI s0ix platforms
From: Rafael J. Wysocki
Date: Fri Feb 27 2026 - 13:43:17 EST
On Fri, Feb 27, 2026 at 4:00 PM Antheas Kapenekakis <lkml@xxxxxxxxxxx> wrote:
>
> Hi everyone,
> now that the kernel merge window is over, I will slowly get back to
> cleaning this series up
>
> I already have some feedback that I will address with V2.
>
> Specifically, we found out that the resume DSM needs to always be
> called and it merged with 7.0. So I will rebase on top of it, remove
> the patch that added it, and rework the logic to always call resume
> before sleep exit. I am not sure how I will tackle this or whether it
> will involve reshaping the FSM states.
>
> Then, there was a compilation warning reported by the kernel bot.
>
> Afterwards, I reviewed the feedback in the Phoronix article. People
> would like to have an option to turn this feature off, or perhaps
> force it off. We could add a Y/n Kconfig for the sysfs patch
> defaulting to Y that enables it, which will be the appropriate option
> for consumer kernels. Or a kernel command line parameter so that users
> do not need to produce their own kernel.
>
> Finally, there is the issue of the Ally devices, which will need a
> partial cleanup that needs to go through platform-x86 and hid core,
> which would make this series touch 3 subsystems. I would tend towards
> omitting it for V2 to keep a short(er) cc list, but I can produce it
> for testing as an addendum.
>
> I have my plate full for the next week, so if you would like for me to
> consider some feedback, next week would be a good time to review this
> series.
I have some feedback already, but I'm not sure when I can get to it
realistically. I'm already starting to be oversubscribed for next
week, unfortunately.