Re: [PATCH 2/2] soc: qcom: ubwc: Remove redundant glymur_data

[Dmitry Baryshkov]

On Fri, Feb 27, 2026 at 06:56:15PM +0100, Krzysztof Kozlowski wrote:
> UBWC data for Glymur is exactly the same as one for SM8750, except
> representing same ubwc_swizzle with value instead of defines, so reduce
> code duplication by reusing older entry.

I'm sorry, I'd like to ask to defer this patch, we are discussing
whether this data is correct or not.

> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> ---
>  drivers/soc/qcom/ubwc_config.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
> index 63e77fceb6b8..eb71b2356c75 100644
> --- a/drivers/soc/qcom/ubwc_config.c
> +++ b/drivers/soc/qcom/ubwc_config.c
> @@ -208,16 +208,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data = {
>  };
>  
>  static const struct qcom_ubwc_cfg_data sm8750_data = {
> -	.ubwc_enc_version = UBWC_5_0,
> -	.ubwc_dec_version = UBWC_5_0,
> -	.ubwc_swizzle = 6,
> -	.ubwc_bank_spread = true,
> -	/* TODO: highest_bank_bit = 15 for LP_DDR4 */
> -	.highest_bank_bit = 16,
> -	.macrotile_mode = true,
> -};
> -
> -static const struct qcom_ubwc_cfg_data glymur_data = {
>  	.ubwc_enc_version = UBWC_5_0,
>  	.ubwc_dec_version = UBWC_5_0,
>  	.ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 |
> @@ -234,7 +224,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
>  	{ .compatible = "qcom,apq8074", .data = &no_ubwc_data },
>  	{ .compatible = "qcom,apq8096", .data = &msm8998_data },
>  	{ .compatible = "qcom,kaanapali", .data = &kaanapali_data, },
> -	{ .compatible = "qcom,glymur", .data = &glymur_data},
> +	{ .compatible = "qcom,glymur", .data = &sm8750_data},
>  	{ .compatible = "qcom,msm8226", .data = &no_ubwc_data },
>  	{ .compatible = "qcom,msm8916", .data = &no_ubwc_data },
>  	{ .compatible = "qcom,msm8917", .data = &no_ubwc_data },
> -- 
> 2.51.0
> 

-- 
With best wishes
Dmitry