Re: [PATCH v3] ACPI: OSL: Poweroff when encountering a fatal ACPI error

From: Rafael J. Wysocki

Date: Fri Feb 27 2026 - 15:41:39 EST


On Fri, Feb 27, 2026 at 8:55 PM Armin Wolf <W_Armin@xxxxxx> wrote:
>
> Am 27.02.26 um 20:50 schrieb Armin Wolf:
>
> > Am 26.02.26 um 19:46 schrieb Rafael J. Wysocki:
> >
> >> On Thu, Feb 26, 2026 at 7:35 AM Armin Wolf <W_Armin@xxxxxx> wrote:
> >>> Am 25.02.26 um 22:28 schrieb Rafael J. Wysocki:
> >>>
> >>>> On Wed, Feb 25, 2026 at 12:06 AM Armin Wolf <W_Armin@xxxxxx> wrote:
> >>>>> Am 04.02.26 um 22:29 schrieb Armin Wolf:
> >>>>>
> >>>>>> The ACPI spec states that the operating system should respond
> >>>>>> to a fatal ACPI error by "performing a controlled OS shutdown in
> >>>>>> a timely fashion". Comply with the ACPI specification by powering
> >>>>>> off the system when ACPICA signals a fatal ACPI error. Users can
> >>>>>> still disable this behavior by using the acpi.poweroff_on_fatal
> >>>>>> kernel option to work around firmware bugs.
> >>>>> Any updates on this?
> >>>> I was about to apply it, but then I thought that I was not sure about
> >>>> the Kconfig option.
> >>>>
> >>>> I don't see much value in it TBH. If you agree, I'll just apply
> >>>> the
> >>>> patch without that part.
> >>>>
> >>>> Thanks!
> >>> You can drop the Kconfig option if you want.
> >> OK, applied as 7.1 material.
> >>
> >> Please double check
> >> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6f09a7009a1d7a132ddce3a8dd0c46aac66ad8e2
> >>
> >
> > Looks good to me, except that the include of kconfig.h should be
> > dropped now.
> >
> > Thanks,
> > Armin Wolf
> >
> I also just noticed that we still need to include panic.h for add_taint().

It complied regardless, likely because kernel.h was included, but yes.

> Should i send a new revision?

No need, I've just updated it by hand and pushed it out.