Re: [PATCH v2 7/7] media: iris: add platform data for kaanapali
From: Dmitry Baryshkov
Date: Sat Feb 28 2026 - 02:37:05 EST
On Fri, Feb 27, 2026 at 04:48:31PM +0100, Krzysztof Kozlowski wrote:
> On 27/02/2026 15:11, Vikash Garodia wrote:
> > +
> > +#include <dt-bindings/media/qcom,iris.h>
> > +
> > +#define VIDEO_REGION_VM0_SECURE_NP_ID 1
> > +#define VIDEO_REGION_VM0_NONSECURE_NP_ID 5
> > +
> > +static const char *const kaanapali_clk_reset_table[] = {
> > + "bus0",
> > + "bus1",
> > + "core",
> > + "vcodec0_core",
> > +};
>
> How many copies do you want of this? Data definition never goes to
> headers. That's standard C rules.
It's not. It's a custom, but not a rule.
--
With best wishes
Dmitry