Re: [PATCH v4 3/3] mmc: dw_mmc: Using devm_clk_get_optional() for biu_clk

[Krzysztof Kozlowski]

On 28/02/2026 07:24, ping.gao wrote:
> From: Ping Gao <ping.gao@xxxxxxxxxxx>
> 
> By using devm_clk_get_optional, if clk is optional for device and not define in dts
> it will return NULL, then clk_prepare_enable/clk_disable_unprepare for biu_clk is safe to
> bail out internally.
> 
> before biu_clk in dwmmc driver devm_clk_get fail, but it's ERR_PTR,
> not null,it will panic when call clk_prepare
> log is below:
> [7:   binder:436_2: 4998] Unable to handle kernel paging request at virtual address fffffffffffffffe
> [7:   binder:436_2: 4998] Mem abort info:
> [7:   binder:436_2: 4998]   ESR = 0x0000000096000005
> [7:   binder:436_2: 4998]   EC = 0x25: DABT (current EL), IL = 32 bits
> [7:   binder:436_2: 4998]   SET = 0, FnV = 0
> [7:   binder:436_2: 4998]   EA = 0, S1PTW = 0
> [7:   binder:436_2: 4998]   FSC = 0x05: level 1 translation fault


No, we don't support here your downstream kernel.

Start working on upstream instead, please.

Best regards,
Krzysztof