Re: [PATCH v4 3/3] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller

[Dmitry Baryshkov]

On Fri, Feb 27, 2026 at 11:26:07AM +0530, Swati Agarwal wrote:
> On Thu, Feb 26, 2026 at 12:36 PM Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxxxxxxxx> wrote:
> >
> > On Thu, Feb 26, 2026 at 11:38:35AM +0530, Swati Agarwal wrote:
> > > Enable the tertiary usb controller connected to micro usb port in OTG mode
> > > on Lemans EVK platform.
> > >
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Swati Agarwal <swati.agarwal@xxxxxxxxxxxxxxxx>
> > > ---
> > >  arch/arm64/boot/dts/qcom/lemans-evk.dts | 52 +++++++++++++++++++++++++
> > >  1 file changed, 52 insertions(+)
> > >
> > > @@ -132,6 +151,15 @@ platform {
> > >               };
> > >       };
> > >
> > > +     usb2_vbus: regulator-usb2-vbus {
> >
> > What is the name (and the label) for the VBus regulator for the first
> > connector? It's visible just under your chunk. Why your chunk doesn't
> > use a similar name?
> Hi Dmitry,
> 
> As per Bjorn previous comment on v2 patch, "use supply name as per
> schematics" so that's the reason I followed that and created a label
> as per regulator name.
> For eg:- if the regulator name is vmmc_sdc then label vmmc_sdc:
> regulator-vmmc-sdc.
> In my case the regulator name in schematics is usb2_vbus, then the
> label I used is usb2_vbus: regulator-usb2-vbus .

Then please add a commit, bringing the other VBUS supply into the shape.
It doesn't look correct to have two VBUS supplies, which are defined
differently.

> 
> Regards,
> Swati

-- 
With best wishes
Dmitry