Re: [PATCH] pinctrl: cy8c95x0: Use proper error code
From: Andy Shevchenko
Date: Sat Feb 28 2026 - 05:13:36 EST
On Fri, Feb 27, 2026 at 08:05:38PM -0600, Ethan Tidmore wrote:
> The function cy8c95x0_irq_pending() returns type bool not an error code.
>
> Use error code -EIO if cy8c95x0_irq_pending() fails.
>
> Detected by Smatch:
> drivers/pinctrl/pinctrl-cy8c95x0.c:1303 cy8c95x0_irq_setup() warn:
> passing positive error code '1' to 'dev_err_probe'
I sent already a patch and the code is -EBUSY, because if we ever get non-zero
here, it means that IO was fine, the interrupt status was not cleared.
--
With Best Regards,
Andy Shevchenko