Re: [PATCH v8 02/18] dt-bindings: media: qcom,x1e80100-camss: Convert from inline PHY definitions to PHY handles

[Krzysztof Kozlowski]

On 27/02/2026 23:01, Christopher Obbard wrote:
> Hi Bryan,
> 
> On Wed, 2026-02-25 at 15:11 +0000, Bryan O'Donoghue wrote:
>> We currently do not have an upstream user of the x1e CAMSS schema which
>> allows us to make this the first platform to treat the CSI PHYs as separate
>> devices in much the same way as we treat the CCI block as separate devices.
>>
>> Convert the embedded CSIPHY node data to simple phys = <> removing all of
>> the PHY specific stuff previously embedded.
>>
>> I gave some serious thought to making the Test Pattern Generators TPGs into
>> PHY nodes also but, unlike the CSIPHYs the TPGs have no dedicated external
>> pins nor regulators.
>>
>> The CSIPHYs OTOH have dedicated in-fact generally unmuxed pins on Qualcomm
>> SoCs and each CSIPHY has its own set of input power rails usually 0p8 and
>> 1p2.
>>
>> Instead of defining the CSIPHYs as children of the CAMSS block, we take the
>> same approach as the CCI/I2C bus dedicated to CAMSS and define the CSIPHYs
>> as their own nodes.
>>
>> Remove the embedded CSIPHY specific data and give CAMSS regular,
>> bog-standard phys = <>;
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> 
> Reviewed-by: Christopher Obbard <christopher.obbard@xxxxxxxxxx>


This is surprising since I clearly object to these patches and pointed
out issues.

This is also obsolete version, thus your review will not apply to new
one (it's different).

Best regards,
Krzysztof