Re: [PATCH 1/6] ARM: dts: microchip: sama7d65: add LCD controller

[Claudiu Beznea]

On 2/25/26 10:54, Manikandan Muralidharan wrote:
> From: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
>
> Add support for LCD controller node
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@xxxxxxxxxxxxx>
> ---
>   arch/arm/boot/dts/microchip/sama7d65.dtsi | 26 +++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> index e21556f46384..b2fe76115aec 100644
> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> @@ -278,6 +278,32 @@ sdmmc1: mmc@e1208000 {
>   			status = "disabled";
>   		};
>   
> +		xlcdc: lcd-controller@e1400000{

Missing a space here -------------------------^

I can adjust it while applying.

Other than that:

Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>

> +			compatible = "microchip,sama7d65-xlcdc";
> +			reg = <0xe1400000 0x2000>;
> +			interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 56>, <&pmc PMC_TYPE_GCK 56>, <&clk32k 1>;
> +			clock-names = "periph_clk", "sys_clk", "slow_clk";
> +			status = "disabled";
> +
> +			display-controller {
> +				compatible = "atmel,hlcdc-display-controller";
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +				};
> +			};
> +
> +			pwm {
> +				compatible = "atmel,hlcdc-pwm";
> +				#pwm-cells = <3>;
> +			};
> +		};
> +
>   		aes: crypto@e1600000 {
>   			compatible = "microchip,sama7d65-aes", "atmel,at91sam9g46-aes";
>   			reg = <0xe1600000 0x100>;