Re: [REGRESSION] Suspend broken on 6.19.4

[Sasha Levin]

On Sat, Feb 28, 2026 at 02:58:54PM +0100, Rafael J. Wysocki wrote:
> On Sat, Feb 28, 2026 at 2:51 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> > On Sat, Feb 28, 2026 at 1:40 PM Athul Krishna
> > <athul.krishna.kr@xxxxxxxxxxxxxx> wrote:
> > >
> > > Device: Asus Zephyrus G14 (GA402RJ)
> > > CPU: Ryzen 7 6700H
> > > iGPU: Radeon 680M
> > >
> > > Problem: Suspend broken on 6.19.4. On closing the lid or systemctl suspend, screen turns off but device does not fully power down.
> > > No obvious errors in dmesg except:
> > > [  219.151441] amd_pmc AMDI0007:00: Last suspend didn't reach deepest state
> > > [  219.164301] ACPI: EC: interrupt unblocked
> > >
> > > Bisected:
> > > commit 6cfed39c2ce64ac024bbde458a9727105e0b8c66
> > > Author: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > > Date:   Tue Dec 23 18:09:11 2025 +0800
> > >
> > >     ACPI: processor: Update cpuidle driver check in __acpi_processor_start()
> > >
> > >     [ Upstream commit 0089ce1c056aee547115bdc25c223f8f88c08498 ]
> > >
> > >     Commit 7a8c994cbb2d ("ACPI: processor: idle: Optimize ACPI idle
> > >     driver registration") moved the ACPI idle driver registration to
> > >     acpi_processor_driver_init() and acpi_processor_power_init() does
> > >     not register an idle driver any more.
> > >
> > >     Accordingly, the cpuidle driver check in __acpi_processor_start() needs
> > >     to be updated to avoid calling acpi_processor_power_init() without a
> > >     cpuidle driver, in which case the registration of the cpuidle device
> > >     in that function would lead to a NULL pointer dereference in
> > >     __cpuidle_register_device().
> > >
> > >     Fixes: 7a8c994cbb2d ("ACPI: processor: idle: Optimize ACPI idle driver registration")
> > >     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > >     Reviewed-by: Mario Limonciello (AMD) <superm1@xxxxxxxxxx>
> > >     Tested-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
> > >     Link: https://patch.msgid.link/20251223100914.2407069-4-lihuisong@xxxxxxxxxx
> > >     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > >     Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > >
> > > Reverting the commit or downgrading to 6.19.3 resolves the issue.
> > > Attached dmesg and lspci.
> >
> > Is this problem also present in 7.0-rc1?
>
> To my eyes, this commit shouldn't have been backported to 6.19.y
> because the one fixed by it was reverted in the meantime and only
> re-added in 7.0-rc1.
>
> Sasha, Greg, how do I request dropping this one from -stable?

Now reverted, thanks :)

--
Thanks,
Sasha