Re: [PATCH] pinctrl: mediatek: common-v1: introduce per-function multibase control

[Akari Tsuyukusa]

On Mon, Jan 12, 2026 at 5:31 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
> Thanks for the patch!
> What you're saying here makes a lot of sense, but there's one big question for you.
>
> Have you considered migrating those pinctrl drivers to use a PIN_FIELD_BASE()
> like it's being done for all other(/newer) MediaTek SoCs?
>
> Why would this not be applicable for those old ones?

Hi Angelo,

Thanks for your review and sorry for the too late response.

I am developing the pinctrl driver for MT6589 and initially based
it on the MT8135 driver, because those two SoCs are very similar.
However, I realized that the hard-coded multi-base settings in v1
are not compatible with MT6589, which led me to create this patch.

After looking at v2, it seems likely compatible with MT6589 as well,
so I will proceed with my development based on v2.

Also, this patch has two flaws:

- It hard-codes the behavior of mt8365_set_clr_mode, which would
  cause issues if there are other SoCs similar to MT8365.
- spec_ies_smt_set expects the IES and SMT registers to be on the same
  base; if an SoC does not follow this, additional handling will be required.

Please ignore this patch for now.

Best regards,
Akari