Re: [PATCH net-next v4] net: mana: Add MAC address to vPort logs and clarify error messages

[Jakub Kicinski]

On Wed, 25 Feb 2026 11:22:41 -0800 Erni Sri Satya Vennela wrote:
> -			dev_err(hwc->dev, "HWC: Request timed out: %u ms\n",
> -				hwc->hwc_timeout);
> +			dev_err(hwc->dev, "%s:%d: Command 0x%x timed out: %u ms\n",
> +				__func__, __LINE__, command, hwc->hwc_timeout);

Please don't include __LINE__, they are meaningless given the amount of
backporting that usually happens in the kernel. The string should be
unique enough to identify the error, which I think yours is given the
__func__ + text you have.
-- 
pw-bot: cr