Re: [PATCH v5 4/8] dt-bindings: iommu: Add spacemit/t100 features

From: Lv Zheng

Date: Sat Feb 28 2026 - 22:50:53 EST


On 3/1/2026 5:58 AM, Conor Dooley wrote:
On Sat, 28 Feb 2026 22:44:49 +0800, Lv Zheng <lv.zheng@xxxxxxxxxxxxxxxxxx> wrote:
Adds device tree bindings for SpacemiT T100 specific features by
introducing spacemit,t100 compatible. T100 contains distributed IOATCs,
each of which exposes pmiv interrupt.

Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Jingyu Li <joey.li@xxxxxxxxxxxx>

Patch content here is fine, but the signoff chain on this patch is not
right. What did Jingyu do? You're author and submitter so either Jingyu
did nothing and should be removed, or is a co-developer which requires
attribution via the co-developed-by tag. If the latter, their signoff
should be before yours (the submitter is always last).

pw-bot: changes-requested

She is responsible for the common HPM part, and I just gave my comments to help to improve the quality of that implementation.
I was just focusing on enabling and maintaining the T100 specific features.

Our patches will go each other's local repository, leaving such tracks. That means the patch from me is Reviewed-and-tested-by her.
And I'm responsible for sending the whole patchset for upstreaming.

Cheers,
Lv


Cheers,
Conor.