Re: [PATCH v3 2/6] arm64: dts: qcom: ipq8074: Add the IMEM node
From: Krzysztof Kozlowski
Date: Sun Mar 01 2026 - 06:29:24 EST
On Sat, Feb 28, 2026 at 06:38:01PM +0530, Kathiravan Thirumoorthy wrote:
> Add the IMEM node to the device tree to extract debugging information
> like system restart reason, which is populated via IMEM. Define the
> IMEM region to enable this functionality.
>
> As described, overall IMEM region is 24KB but only initial 4KB is
> accessible by all masters in the SoC.
>
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 256e12cf6d54417582a8b50e061f40719a4004a1..086b34ba7b09d68e24d2c1da28f303357ce503ea 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -625,6 +625,17 @@ qpic_nand: nand-controller@79b0000 {
> status = "disabled";
> };
>
> + sram@8600000 {
> + compatible = "qcom,ipq8074-imem", "mmio-sram";
> + reg = <0x08600000 0x6000>;
> + ranges = <0 0x08600000 0x6000>;
Nope.
> +
> + no-memory-wc;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
Nope. These are completely redundant and not needed. Post complete DTS
so you will see how your DTS and binding DO NOT WORK. Posting half-baked
code gives you opposite impression - that it is working...
Best regards,
Krzysztof