Re: [PATCH] i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller

From: Mika Westerberg

Date: Mon Mar 02 2026 - 00:38:22 EST


On Sat, Feb 28, 2026 at 12:47:47PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 27, 2026 at 09:52:48PM +0000, Moritz Fischer wrote:
> > On Fri, Feb 27, 2026 at 08:51:26PM +0200, Andy Shevchenko wrote:
> > > On Fri, Feb 27, 2026 at 06:23:07PM +0000, Moritz Fischer wrote:
> > > > Define a new ACPI HID for GOOG5000 as used on Google Axion.
> > > >
> > > > This has been validated on Silicon.
> >
> > > > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > > > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > > Cc: Jan Dabros <jsd@xxxxxxxxxxxx>
> >
> > > Please, put Cc list...
> >
> > > > Signed-off-by: Moritz Fischer <moritzf@xxxxxxxxxx>
> > > > ---
> >
> > > ...somewhere here. It will have the same effect on the email. But the
> > > positive
> > > outcome is the noise reduction in the commit message.
> >
> > > See also this discussion (patch 18 subthread):
> > > https://lore.kernel.org/lkml/20260123113708.416727-19-bigeasy@xxxxxxxxxxxxx/
> >
> > Ok, fair. Do you want me to resend or do you want to patch it when
> > applying?
>
> I'm not a maintainer, so from my p.o.v. the safest option is to send a new
> version with all data gathered and put properly (Cc list, ACPI excerpt, et
> cetera) in one place.

I don't think the excerpt adds any real value. Only thing that really
matters is that the ACPI ID is "correct" meaning that it is properly
assigned by the owner and that's true here. For the CC list does not matter
to me but if you want to resend with that fixed no problem.

Either way,

Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>