Re: [PATCH 2/2] dt-bindings: usb: cdns,usb3: Add support for USBSSP

[Peter Chen]

On 26-03-02 08:29:40, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On Mon, Mar 02, 2026 at 11:03:34AM +0800, Peter Chen wrote:
> > Extend the Cadence USBSS DRD binding to also cover the USBSSP
> > controller by adding "cdns,usbssp" to the compatible enum.
> 
> So here you explan what you did
> 
> >
> > The USBSSP is the next-generation Cadence USB controller IP. It adds
> > SuperSpeed Plus (USB 3.1 gen2x1, 10 Gbps) support and uses an
> > XHCI-based device controller. The register layout and resource model
> > (otg/xhci/dev memory regions; host/peripheral/otg interrupts) are
> > identical to the USBSS, so both controllers share the same binding
> 
> Heh, identical but completely incompatible. If you are using Claude then
> at least read its feedback - what does it say when devices are 100%
> compatible?

You are right, that was a contradictory statement. I have added both
the same and differences at the last reply. I will rewrite the description
to be accurate.

> 
> > and the same platform driver (cdns3-plat.c).
> >
> > Changes to the binding:
> 
> And here. How many times more?
> 
> > - compatible: const -> enum with cdns,usb3 and cdns,usbssp
> > - maximum-speed: add super-speed-plus
> > - Add USBSSP example
> 
> Pointless. Explain WHY are you doing this, why do we even want this
> generic compatible, not paste here Claude microslop output.
> 

Fair point. Will rewrite the commit message for v2 to focus on WHY.
Thanks for the review.

-- 

Best regards,
Peter