Re: [PATCH v3 2/2] platform/x86: hp-wmi: Add missing LED Kconfig dependencies

[Ilpo Järvinen]

On Sat, 28 Feb 2026, edip@xxxxxxxxx wrote:

> From: Edip Hazuri <edip@xxxxxxxxx>
> 
> Add depends on LEDS_CLASS and LEDS_CLASS_MULTICOLOR for the
> multicolor keyboard backlight support.
> 
> Signed-off-by: Edip Hazuri <edip@xxxxxxxxx>
> ---
>  drivers/platform/x86/hp/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/Kconfig b/drivers/platform/x86/hp/Kconfig
> index dd51491b9bcd..02668ebc3020 100644
> --- a/drivers/platform/x86/hp/Kconfig
> +++ b/drivers/platform/x86/hp/Kconfig
> @@ -40,6 +40,8 @@ config HP_WMI
>  	depends on ACPI_EC
>  	depends on ACPI_WMI
>  	depends on INPUT
> +	depends on LEDS_CLASS
> +	depends on LEDS_CLASS_MULTICOLOR
>  	depends on RFKILL || RFKILL = n
>  	select POWER_SUPPLY
>  	select INPUT_SPARSEKMAP

Doesn't this lead to a build failure if only 1/2 is applied but 2/2 is not 
(which can happen e.g. during git bisect)? It's never acceptable to cause 
a build failure if only a part of the series is applied.

-- 
 i.