Re: [PATCH 1/4] iio: orientation: hid-sensor-rotation: add timestamp hack to not break userspace

[Jonathan Cameron]

On Mon, 2 Mar 2026 09:18:56 -0600
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> On 3/2/26 2:50 AM, Andy Shevchenko wrote:
> > On Sun, Mar 01, 2026 at 02:24:50PM -0600, David Lechner wrote:  
> >> Add a hack to push two timestamps in the hid-sensor-rotation scan data
> >> to avoid breaking userspace applications that depend on the timestamp
> >> being at the incorrect location in the scan data due to unintentional
> >> misalignment in older kernels.
> >>
> >> When this driver was written, the timestamp was in the correct location
> >> because of the way iio_compute_scan_bytes() was implemented at the time.
> >> (Samples were 24 bytes each.) Then commit 883f61653069 ("iio: buffer:
> >> align the size of scan bytes to size of the largest element") changed
> >> the computed scan_bytes to be a different size (32 bytes), which caused
> >> iio_push_to_buffers_with_timestamp() to place the timestamp at an
> >> incorrect offset.
> >>
> >> There have been long periods of time (6 years each) where the timestamp
> >> was in either location, so to not break either case, we open-code the
> >> timestamps to be pushed to both locations in the scan data.  
> > 
> > ...
> >   
> >> +		/*
> >> +		 * HACK: There are two copies of the same timestamp in case of  
> > 
> > Usually we use FIXME in such cases. HACK is something which goes with
> > "do not apply".
> > 
> > Does it mean it will stay forever?  
> 
> Yes, it will have to stay forever because we can't break userspace.
> 
> My intention here was for HACK to mean "do not copy to another driver".
> 
> 
> If we think that no one is depending on timestamps being in the wrong
> offset, we could omit this change and apply only the rest of the series.
> And then only apply this patch if anyone complains. I am just trying to
> play it safe here and not risk breaking things.

I think it makes sense, but maybe label it something like

ABI regression avoidance: 

Good idea to just keep the wrongly aligned one as it removes the
risk and should do no harm as correct userspace should ignore the
second copy as it's in the padding.

Jonathan