Re: [PATCH 11/21] nvme-auth: common: use crypto library in nvme_auth_generate_digest()

[Hannes Reinecke]

On 3/2/26 08:59, Eric Biggers wrote:
> For the HMAC computation in nvme_auth_generate_digest(), use the crypto
> library instead of crypto_shash.  This is simpler, faster, and more
> reliable.  Notably, this eliminates the crypto transformation object
> allocation for every call, which was very slow.
>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>   drivers/nvme/common/auth.c | 87 +++++++++++---------------------------
>   1 file changed, 25 insertions(+), 62 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich