Re: [PATCH RFT v2 1/2] arm64: dts: qcom: glymur: Describe display related nodes

[Abel Vesa]

On 26-01-27 13:48:24, Konrad Dybcio wrote:
> On 1/13/26 4:00 PM, Abel Vesa wrote:
> > From: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > 
> > The MDSS (Mobile Display SubSystem) on Glymur comes with 4 DisplayPort
> > controllers. Describe them along with display controller and the eDP
> > PHY. Then, attach the combo PHYs link and vco_div clocks to the Display
> > clock controller and link up the PHYs and DP endpoints in the graph.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/glymur.dtsi | 431 ++++++++++++++++++++++++++++++++++-
> >  1 file changed, 423 insertions(+), 8 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > index 53b8ab7580bd..0b7b2756508c 100644
> > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > @@ -2377,6 +2377,7 @@ port@2 {
> >  					reg = <2>;
> >  
> >  					usb_dp_qmpphy_dp_in: endpoint {
> > +						remote-endpoint = <&mdss_dp0_out>;
> >  					};
> >  				};
> >  			};
> > @@ -2447,6 +2448,7 @@ port@2 {
> >  					reg = <2>;
> >  
> >  					usb1_ss1_qmpphy_dp_in: endpoint {
> > +						remote-endpoint = <&mdss_dp1_out>;
> >  					};
> >  				};
> >  			};
> > @@ -2466,6 +2468,27 @@ usb_2_hsphy: phy@fa0000 {
> >  			status = "disabled";
> >  		};
> >  
> > +		mdss_dp3_phy: phy@faac00 {
> 
> This definitely says eDP2 in the docs..

Sorry for the late reply.

I suggest we keep using the mdss_dp3_phy here, otherwise it will
be confusing as to suggest we use the mdss_dp2_phy with the mdss_dp3
controller.

So I will respin with this as is.

All other comments will be addressed as you suggested, in the next 
version.

Thanks for reviewing.