Re: [PATCH] futex: add missing function parameter comments

[André Almeida]

Hi Randy,

Thanks for your patch

Em 28/02/2026 04:17, Randy Dunlap escreveu:
> Correct or add the missing function parameter kernel-doc comments
> to avoid warnings:
>
> Warning: include/asm-generic/futex.h:38 function parameter 'op' not
>   described in 'futex_atomic_op_inuser_local'
> Warning: include/asm-generic/futex.h:38 function parameter 'oparg' not
>   described in 'futex_atomic_op_inuser_local'
> Warning: include/asm-generic/futex.h:38 function parameter 'oval' not
>   described in 'futex_atomic_op_inuser_local'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> ---
> Cc: Thomas Gleixner <tglx@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>
> Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>
> Cc: André Almeida <andrealmeid@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: linux-arch@xxxxxxxxxxxxxxx
>
>   include/asm-generic/futex.h |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- linux-next-20260211.orig/include/asm-generic/futex.h
> +++ linux-next-20260211/include/asm-generic/futex.h
> @@ -25,7 +25,9 @@
>    *			  argument and comparison of the previous
>    *			  futex value with another constant.
>    *
> - * @encoded_op:	encoded operation to execute
> + * @op:		encoded operation to execute

I think we don't need the "encoded" part anymore

> + * @oparg:	operation code (one of FUTEX_OP_...)

This is the argument of the operation, e.g when op is FUTEX_OP_ADD, 
oparg is the value to be added.

> + * @oval:	previous value at @uaddr on successful return
>    * @uaddr:	pointer to user space address
>    *
>    * Return: