RE: [PATCH v1 1/2] dt-bindings: mmc: snps,dwcmshc-sdhci: add HPE GSC dwcmshc compatible

[Hawkins, Nick]

Hi Conor,

> > +    mmc@c0100000 {
> > +      compatible = "hpe,gsc-dwcmshc";
> > +      reg = <0xc0100000 0x1000>, <0xc0000110 0x4>;

> A 0x4 sized region is always incredibly suspect. What is at address
> 0xc000010c or 0xc0000114? Usually in these sorts of scenarios, it ends
> up being that there's some sort of misc. register region of which this
> is just one register, that should be represented as a syscon.

The first register set will be the actual device / IP we are working with. 
The second is as you suggested is just a misc register region.
I will work on handling that for the second revision of the patch series.

Thank you,

-Nick