Re: [PATCH v2 3/7] media: iris: add iris vpu bus support and register it with iommu_buses

[Vikash Garodia]

On 2/27/2026 9:19 PM, Krzysztof Kozlowski wrote:
> On 27/02/2026 15:11, Vikash Garodia wrote:
> > Add iris vpu bus support and hooks the new bus into the iommu_buses
> > list. Iris devices need their own bus so that each iris device can run
> > its own dma_configure() logic.
> >
> > Co-developed-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/iommu/iommu.c                           |  4 ++++
> >   drivers/media/platform/qcom/iris/Makefile       |  4 ++++
> >   drivers/media/platform/qcom/iris/iris_vpu_bus.c | 32 +++++++++++++++++++++++++
> >   include/linux/iris_vpu_bus.h                    | 13 ++++++++++
> >   4 files changed, 53 insertions(+)
> >
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index 35db5178095404fec87cd0f18e44ea97cf354e78..fd5fb7c10da22ab548d359ca1f44504acc3d646c 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -13,6 +13,7 @@
> >   #include <linux/bug.h>
> >   #include <linux/types.h>
> >   #include <linux/init.h>
> > +#include <linux/iris_vpu_bus.h>
> >   #include <linux/export.h>
> >   #include <linux/slab.h>
> >   #include <linux/errno.h>
> > @@ -178,6 +179,9 @@ static const struct bus_type * const iommu_buses[] = {
> >   #ifdef CONFIG_CDX_BUS
> >   	&cdx_bus_type,
> >   #endif
> > +#if IS_ENABLED(CONFIG_VIDEO_QCOM_IRIS)
> > +	&iris_vpu_bus_type,
> > +#endif
> >   };
> >   
> >   /*
> > diff --git a/drivers/media/platform/qcom/iris/Makefile b/drivers/media/platform/qcom/iris/Makefile
> > index 2abbd3aeb4af07e52bf372a4b2f352463529c92c..6f4052b98491aeddc299669334d4c93e9a3420e4 100644
> > --- a/drivers/media/platform/qcom/iris/Makefile
> > +++ b/drivers/media/platform/qcom/iris/Makefile
> > @@ -31,3 +31,7 @@ qcom-iris-objs += iris_platform_gen1.o
> >   endif
> >   
> >   obj-$(CONFIG_VIDEO_QCOM_IRIS) += qcom-iris.o
> > +
> > +ifdef CONFIG_VIDEO_QCOM_IRIS
> > +obj-y += iris_vpu_bus.o
> > +endif
> > diff --git a/drivers/media/platform/qcom/iris/iris_vpu_bus.c b/drivers/media/platform/qcom/iris/iris_vpu_bus.c
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..34ce78d9b0ff1feda15ba4f060a56d02749a0858
> > --- /dev/null
> > +++ b/drivers/media/platform/qcom/iris/iris_vpu_bus.c
> > @@ -0,0 +1,32 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright (c) 2026 Qualcomm Innovation Center, Inc. All rights reserved.
> > + */
> > +
> > +#include <linux/device.h>
> > +#include <linux/of_device.h>
> > +
> > +#include "iris_platform_common.h"
> > +
> > +static int iris_vpu_bus_dma_configure(struct device *dev)
> > +{
> > +	struct iris_context_bank *cb = dev_get_drvdata(dev);
> > +
> > +	if (!cb)
> > +		return -ENODEV;
> > +
> > +	return of_dma_configure_id(dev, dev->parent->of_node, true, &cb->f_id);
>
>
> Apply this patch and build it. Does it build?

it was incorrectly organized, since the struct was defined in subsequent 
patch. Will fix this in next revision.

> Best regards,
> Krzysztof

Regards,
Vikash