Re: [PATCH v2 3/4] hwmon: axi-fan: don't use driver_override as IRQ name
From: Frank Li
Date: Tue Mar 03 2026 - 16:04:25 EST
From: Frank Li (AI-BOT) <frank.li@xxxxxxx>
> ret = devm_request_threaded_irq(&pdev->dev, ctl->irq, NULL,
> axi_fan_control_irq_handler,
> IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> - pdev->driver_override, ctl);
> + NULL, ctl);
Good catch. Using driver_override as IRQ name is indeed unsafe since it's
not guaranteed to be a valid string. Passing NULL is correct here; the
devm IRQ helpers will fall back to dev_name() which is always valid.
The fix is minimal and addresses the root cause. The error handling path
below looks fine—dev_err_probe() will still work correctly with the NULL
name.
Looks good to me.
AI bot review and may be useless.