[PATCH v2] PCI: probe: Use helper macros and constants
From: hechushiguitu666
Date: Wed Mar 04 2026 - 01:27:43 EST
From: "haoyu.lu" <hechushiguitu666@xxxxxxxxx>
Replace direct resource array access with the pci_resource_n() helper
macro and use MSEC_PER_SEC instead of the bare number 1000.
Changes in v2:
- Use pci_resource_n() for resource array access (Bjorn)
- Use MSEC_PER_SEC (Bjorn)
Signed-off-by: haoyu.lu <hechushiguitu666@xxxxxxxxx>
---
drivers/pci/probe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index bccc7a4bdd79..d5b27d03355c 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -119,7 +119,7 @@ static u64 pci_size(u64 base, u64 maxbase, u64 mask)
* Get the lowest of them to find the decode size, and from that
* the extent.
*/
- size = size & ~(size-1);
+ size = size & ~(size - 1);
/*
* base == maxbase can be valid only if the BAR has already been
@@ -594,7 +594,7 @@ void pci_read_bridge_bases(struct pci_bus *child)
pci_bus_remove_resources(child);
for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++)
- child->resource[i] = &dev->resource[PCI_BRIDGE_RESOURCES+i];
+ child->resource[i] = pci_resource_n(dev, PCI_BRIDGE_RESOURCES + i);
pci_read_bridge_io(child->self,
child->resource[PCI_BUS_BRIDGE_IO_WINDOW], false);
@@ -2600,7 +2600,7 @@ static struct pci_dev *pci_scan_device(struct pci_bus *bus, int devfn)
struct pci_dev *dev;
u32 l;
- if (!pci_bus_read_dev_vendor_id(bus, devfn, &l, 60*1000))
+ if (!pci_bus_read_dev_vendor_id(bus, devfn, &l, 60 * MSEC_PER_SEC))
return NULL;
dev = pci_alloc_dev(bus);
--
2.53.0.windows.1