Re: [PATCH v2] rust: kunit: fix warning when !CONFIG_PRINTK

[David Gow]

Le 04/03/2026 à 10:34 AM, Miguel Ojeda a écrit :
> On Tue, Feb 24, 2026 at 11:38 AM Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
> > If `CONFIG_PRINTK` is not set, then the following warnings are issued
> > during build:
> >
> >    warning: unused variable: `args`
> >      --> ../rust/kernel/kunit.rs:16:12
> >      |
> >    16 | pub fn err(args: fmt::Arguments<'_>) {
> >      |            ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
> >      |
> >      = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
> >
> >    warning: unused variable: `args`
> >      --> ../rust/kernel/kunit.rs:32:13
> >      |
> >    32 | pub fn info(args: fmt::Arguments<'_>) {
> >      |             ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
> >
> > Fix this by adding a no-op assignment using `args` when `CONFIG_PRINTK`
> > is not set.
> >
> > Fixes: a66d733da801 ("rust: support running Rust documentation tests as KUnit ones")
> > Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
>
> Applied to `rust-fixes` -- thanks everyone!
>
> Also Cc: stable@xxxxxxxxxxxxxxx

This is also sitting in kselftest/kunit-fixes:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit-fixes&id=7dd34dfc8dfa92a7244242098110388367996ac3

I don't particularly mind if you'd rather it go through the Rust tree, 
though. Let me know if you want this removed.

Cheers,
-- David