Re: [PATCH 4/4] drm/panel: himax-hx83102: Add support for DSI DCS backlight control

[David Heidelberg]

On 17/02/2026 08:00, Val Packett wrote:

[...]

> +
> +static struct backlight_device *
> +hx83102_create_dcs_backlight(struct mipi_dsi_device *dsi)
> +{
> +	struct device *dev = &dsi->dev;
> +	const struct backlight_properties props = {
> +		.type = BACKLIGHT_RAW,
> +		.brightness = 4095,

Series looks good, just nitpick here.

While this is not OLED, where full brightness reduces the lifetime of display a 
lot, are you sure you want to bring the display backlight up to 100% by default?

Usually I've and others put ~ 50%. It's important to keep display well readable 
until userspace takes over, but not have to be full-throttle :)

David

[...]

--
David Heidelberg