Re: [PATCH v8 16/23] scsi: ufs: mediatek: Clean up logging prints
From: Peter Wang (王信友)
Date: Thu Mar 05 2026 - 04:43:00 EST
On Wed, 2026-03-04 at 15:53 +0100, Nicolas Frattaroli wrote:
> The Linux kernel's log buffer provides many levels of verbosity,
> associated with different semantic meanings. Care should be taken to
> only log useful information to the info level, and log errors to the
> error level.
>
> The MediaTek UFS driver does not do this. It freely logs verbose
> debug
> information to the info level, errors to the info level, and
> sometimes
> errors to the warning level.
>
> Adjust all the wrapped kprintf invocations to rectify this situation.
> Use user-friendly %pe format codes for printing errors where
> possible.
>
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx>
Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>