Re: [net-next,v3,6/8] bng_en: add initial support for ethtool stats display

[Bhargava Chenna Marreddy]

> >         [n-1]: rxq_errors: 0
>
> Unrelated to the previous comment, but could you perhaps not use
> this `[id]: name: value` notation in bng_en? Having spaces in the name
> of the stats in bnxt breaks a bunch of scripts for me. rxq$id_$name is
> the notation majority of the drivers use.

Hi Jakub,

Understood, I'll update the stat names to rxq$id_$name.

> Standard stats does not mean just rtnl_stats. Please TAL at the per
> queue stats for instance. If you think some of the counters don't
> match you can keep them but please include in the commit msg the
> analysis of what counters you considered + what the HW counter is doing
> = why the two don't match.

Thanks for the detailed explanation.

I have reviewed the various kinds of stats and the duplications.
I will add support for the 'per-queue statistics' (netdev_stat_ops)
and remove the redundant counters from ethtool -S.

Thanks,
Bhargava Marreddy

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature