Re: [BUG] usb: cdc-wdm: Missing barriers in ad-hoc lockless buffer

From: Oliver Neukum

Date: Thu Mar 05 2026 - 06:36:20 EST


On 04.03.26 09:41, Gui-Dong Han wrote:
Additionally, the driver relies heavily on set_bit() and test_bit() on
desc->flags for synchronization. These bit operations do not provide
implicit barriers, which might lead to similar ordering issues.

Hi,

going through the driver it seems to me like all relevant cases
are covered by the iuspin spinlock. Do you have any concrete suspicions
or do you generally distrust this style?

Regards
Oliver