Re: [PATCH v2 1/7] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding

From: Vikash Garodia

Date: Thu Mar 05 2026 - 07:29:01 EST




On 3/4/2026 8:37 PM, Krzysztof Kozlowski wrote:
On 03/03/2026 19:10, Vikash Garodia wrote:


...

+ };
diff --git a/include/dt-bindings/media/qcom,iris.h b/include/dt-bindings/media/qcom,iris.h

Filename must match binding/compatible. I asked for this multiple times.


in this case, its applicable for other platforms as well. Naming it as
qcom,kaanapali-iris.h would make it look like kaanapali specific.

I repeated that feedback way too many times.

thanks for the feedback. I’ll fix this in next revision.


NAK

Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx

Best regards,
Krzysztof