Re: [PATCH v9 4/5] gpio: rpmsg: add support for NXP legacy firmware protocol

From: Frank Li

Date: Thu Mar 05 2026 - 10:17:12 EST


From: Frank Li (AI-BOT) <frank.li@xxxxxxx>


> +static int imx_std_cmd_map[] = {

AI: Should be 'static const int' since this is a read-only lookup table.

> + if (msg->cmd >= sizeof(imx_std_cmd_map))

AI: Use ARRAY_SIZE(imx_std_cmd_map) instead of sizeof() for clarity.

because imx_std_cmd_map is array, AI most likely is correct.

Frank