Re: [PATCH v2 1/5] workqueue: Use POOL_BH instead of WQ_BH when checking pool flags

[Song Liu]

On Thu, Mar 5, 2026 at 8:16 AM Breno Leitao <leitao@xxxxxxxxxx> wrote:
>
> pr_cont_worker_id() checks pool->flags against WQ_BH, which is a
> workqueue-level flag (defined in workqueue.h). Pool flags use a
> separate namespace with POOL_* constants (defined in workqueue.c).
> The correct constant is POOL_BH. Both WQ_BH and POOL_BH are defined
> as (1 << 0) so this has no behavioral impact, but it is semantically
> wrong and inconsistent with every other pool-level BH check in the
> file.
>
> Fixes: 4cb1ef64609f ("workqueue: Implement BH workqueues to eventually replace tasklets")
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>

Acked-by: Song Liu <song@xxxxxxxxxx>