Re: [PATCH v4 1/4] x86/microcode: Refactor platform ID enumeration into a helper

[Dave Hansen]

On 3/4/26 17:38, Pawan Gupta wrote:
>> +/*
>> + * Use CPUID to generate a "vfm" value. Useful
>> + * before 'cpuinfo_x86' structures are populated.
>> + */
>> +static u32 intel_cpuid_vfm(void)
>> +{
>> +	u32 eax   = cpuid_eax(1);
>> +	u32 fam   = x86_family(eax);
>> +	u32 model = x86_model(eax);
> Nit, is s/eax/sig/ more clear?
> 
> 	u32 sig   = cpuid_eax(1);
> 	u32 fam   = x86_family(sig);
> 	u32 model = x86_model(sig);

It's debatable. It's nice having the 'sig' explain what's in EAX. But
'sig' is pretty generic and the code is all right here anyway. I think
I'll leave it as 'eax'.