Re: [PATCH v6 2/3] bsg: add io_uring command support to generic layer
From: Yang Xiuwei
Date: Thu Mar 05 2026 - 22:05:14 EST
On 2026-03-05 15:17, Bart Van Assche wrote:
> Please order declarations from longest to shortest.
Done. Will reorder variable declarations from longest to shortest.
> The traditional Linux kernel coding style is to return early in case of
> an error. For the above code that means writing it as follows:
>
> if (!bd->uring_cmd_fn)
> return -EOPNOTSUPP;
>
> return bd->uring_cmd_fn(q, ioucmd, issue_flags, open_for_write);
Done. Will use early return style for error handling.
Will include these changes in v7.
Best regards,
Yang Xiuwei