Re: [PATCH 1/1] ARM: dts: imx6sx: remove fallback compatible string fsl,imx28-lcdif

[Krzysztof Kozlowski]

On 05/03/2026 23:48, Frank Li wrote:
> On Thu, Mar 05, 2026 at 10:34:18PM +0100, Krzysztof Kozlowski wrote:
>> On 05/03/2026 22:23, Frank Li wrote:
>>> i.MX6SX uses the v6 LCDIF controller, while i.MX28 uses the older v4
>>> version. The driver has supported the "fsl,imx6sx-lcdif" compatible string
>>> since the initial commit:
>>>
>>>    commit 45d59d704080 ("drm: Add new driver for MXSFB controller")
>>>
>>> Therefore the fallback compatible string "fsl,imx28-lcdif" is not required
>>> and can be removed.
>>
>> It is required - you are changing the ABI and possibly impacting other
>> users without valid reason ("not required and can be removed" is not a
>> reason).
> 
> In https://lore.kernel.org/imx/42eb2d42-47b0-46b6-92e9-c59473113c2d@xxxxxxx/
> 
> other known user barebox/uboot already fix it.
> 
> https://lore.barebox.org/barebox/20251107210033.2229781-3-a.fatoum@xxxxxxxxxxx/T/#u
> https://git.pengutronix.de/cgit/barebox/commit/?id=c99b937f3a31

And you have entire commit msg to explain the ABI impact...

Best regards,
Krzysztof